Skip to content

SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN - #1372

Merged
yyyyyyyan merged 3 commits into
mainfrom
copilot/sep-1841-update-readme-guidance
Aug 19, 2026
Merged

SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN#1372
yyyyyyyan merged 3 commits into
mainfrom
copilot/sep-1841-update-readme-guidance

Conversation

Copilot AI commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The SEP_INTERNAL_TOKEN row in sidecar/README.md's deployment-inputs table referenced PMM's nginx overlay as the trigger for setting the variable explicitly. That overlay was retired in SEP-1795/SEP-1810 and no longer exists.

  • Replaced the stale "when PMM's nginx overlay pins a specific value" sentence with the condition grounded in shipped code: rotating the token independently of SECRET_KEY (per derive_internal_token in app/core/config.py)
  • Added context on what the token authenticates (service-to-service calls, e.g. scheduled inventory sync)
  • Preserved the HMAC-derivation sentence

Before:

| SEP_INTERNAL_TOKEN | no | Derived from SECRET_KEY by HMAC when unset. Set it explicitly when PMM's nginx overlay pins a specific value. |

After:

| SEP_INTERNAL_TOKEN | no | Authenticates SEP-internal service-to-service calls, such as the scheduled inventory sync. Derived from SECRET_KEY by HMAC when unset, so every process sharing the key resolves the same token. Set it explicitly only to rotate it independently of SECRET_KEY. |

…n sidecar README

Co-authored-by: yyyyyyyan <24644216+yyyyyyyan@users.noreply.github.com>
Copilot AI changed the title [WIP] SEP-1841: Correct side-car README's guidance on SEP_INTERNAL_TOKEN SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN Aug 19, 2026
Copilot AI requested a review from yyyyyyyan August 19, 2026 15:46
@yyyyyyyan
yyyyyyyan marked this pull request as ready for review August 19, 2026 16:13
@yyyyyyyan
yyyyyyyan requested a review from a team as a code owner August 19, 2026 16:13
Copilot AI balanced review requested due to automatic review settings August 19, 2026 16:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Corrects stale sidecar deployment guidance for SEP_INTERNAL_TOKEN.

Changes:

  • Documents the token’s service-to-service authentication purpose.
  • Clarifies HMAC derivation and independent rotation behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@yyyyyyyan
yyyyyyyan merged commit b3f3816 into main Aug 19, 2026
10 of 12 checks passed
@yyyyyyyan
yyyyyyyan deleted the copilot/sep-1841-update-readme-guidance branch August 19, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants