SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN - #1372
Merged
Conversation
…n sidecar README Co-authored-by: yyyyyyyan <24644216+yyyyyyyan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] SEP-1841: Correct side-car README's guidance on SEP_INTERNAL_TOKEN
SEP-1841: Correct sidecar README guidance on when to set SEP_INTERNAL_TOKEN
Aug 19, 2026
yyyyyyyan
marked this pull request as ready for review
August 19, 2026 16:13
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects stale sidecar deployment guidance for SEP_INTERNAL_TOKEN.
Changes:
- Documents the token’s service-to-service authentication purpose.
- Clarifies HMAC derivation and independent rotation behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SEP_INTERNAL_TOKENrow insidecar/README.md's deployment-inputs table referenced PMM's nginx overlay as the trigger for setting the variable explicitly. That overlay was retired in SEP-1795/SEP-1810 and no longer exists.SECRET_KEY(perderive_internal_tokeninapp/core/config.py)Before:
After: